Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SyntaxWarning in graph.py #1278

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Nov 10, 2021

https://github.com/deepmodeling/deepmd-kit/runs/4160505428?check_suite_focus=true#step:8:10

/home/runner/work/deepmd-kit/deepmd-kit/deepmd/utils/graph.py:156: SyntaxWarning: "is not" with a literal. Did you mean "!="?

/home/runner/work/deepmd-kit/deepmd-kit/deepmd/utils/graph.py:156: SyntaxWarning: "is not" with a literal. Did you mean "!="?
@njzjz njzjz requested a review from denghuilu November 10, 2021 07:55
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021

Codecov Report

Merging #1278 (c670ccf) into devel (43fc8b3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel    #1278   +/-   ##
=======================================
  Coverage   75.97%   75.97%           
=======================================
  Files          91       91           
  Lines        7406     7406           
=======================================
  Hits         5627     5627           
  Misses       1779     1779           
Impacted Files Coverage Δ
deepmd/utils/graph.py 73.56% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43fc8b3...c670ccf. Read the comment docs.

@wanghan-iapcm wanghan-iapcm merged commit 77ce651 into deepmodeling:devel Nov 11, 2021
@njzjz njzjz deleted the SyntaxWarning branch November 11, 2021 01:54
njzjz pushed a commit to njzjz/deepmd-kit that referenced this pull request Sep 21, 2023
<!--pre-commit.ci start-->
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.0.277 →
v0.0.278](astral-sh/ruff-pre-commit@v0.0.277...v0.0.278)
<!--pre-commit.ci end-->

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants