Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added all activation functions for model compression. #1283

Merged
merged 18 commits into from
Nov 15, 2021
Merged

Added all activation functions for model compression. #1283

merged 18 commits into from
Nov 15, 2021

Conversation

liangadam
Copy link
Contributor

Now the model with activation functions such as 'relu', 'relu6', 'softplus', 'sigmoid' in descriptor can be compressed, and the output results have been well tested.

Modified related document with activation function.

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

Merging #1283 (dc60e1b) into devel (abec07e) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1283      +/-   ##
==========================================
- Coverage   75.97%   75.89%   -0.09%     
==========================================
  Files          91       91              
  Lines        7406     7414       +8     
==========================================
  Hits         5627     5627              
- Misses       1779     1787       +8     
Impacted Files Coverage Δ
deepmd/utils/tabulate.py 85.23% <0.00%> (-2.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abec07e...dc60e1b. Read the comment docs.

@@ -2,5 +2,18 @@ Training Parameters
======================================
.. note::
One can load, modify, and export the input file by using our effective web-based tool `DP-GUI <https://deepmodeling.org/dpgui/input/deepmd-kit-2.0>`_. All training parameters below can be set in DP-GUI. By clicking "SAVE JSON", one can download the input file for furthur training.


**Available activation functions for descriptor:**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why insert here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there is a lack of guidance on available activation functions, neither in DP-GUI nor for editing 'input.json' by oneself.
You can tell me if there is a more suitable place to add.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's mentioned, though.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine~ It's better to left document work to you because it‘s hard for me to think about it comprehensively.

Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this implementation tested?

@liangadam
Copy link
Contributor Author

How was this implementation tested?

By using dp test to compare the results of models (trained with different activation functions) before and after compression. The test results show that all compressed models are very accurate.
Also,I deliberately add different types of errors to test the error reporting mechanism. The results are sensible.

Moreover, using lammps to run those models to make sure there are no abnormal result.

The following shows an test example:
image

@wanghan-iapcm
Copy link
Collaborator

How was this implementation tested?

By using dp test to compare the results of models (trained with different activation functions) before and after compression. The test results show that all compressed models are very accurate. Also,I deliberately add different types of errors to test the error reporting mechanism. The results are sensible.

Moreover, using lammps to run those models to make sure there are no abnormal result.

The following shows an test example: image

It looks great. Have you tested all types of activation functions you implemented?

@liangadam
Copy link
Contributor Author

How was this implementation tested?

By using dp test to compare the results of models (trained with different activation functions) before and after compression. The test results show that all compressed models are very accurate. Also,I deliberately add different types of errors to test the error reporting mechanism. The results are sensible.
Moreover, using lammps to run those models to make sure there are no abnormal result.
The following shows an test example: image

It looks great. Have you tested all types of activation functions you implemented?

Yes, All of them have been tested~

@amcadmus amcadmus requested a review from njzjz November 15, 2021 00:25
@wanghan-iapcm wanghan-iapcm merged commit 4af4ea5 into deepmodeling:devel Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants