Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updata_deepmd_input when compress #1297

Merged
merged 1 commit into from
Nov 21, 2021

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Nov 19, 2021

This ensures the old model can be compressed by the new program.

This ensures the old model can be compressed by the new program.
@njzjz njzjz requested a review from denghuilu November 19, 2021 21:43
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2021

Codecov Report

Merging #1297 (4ac0f5d) into devel (95e321f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel    #1297   +/-   ##
=======================================
  Coverage   75.89%   75.90%           
=======================================
  Files          91       91           
  Lines        7414     7415    +1     
=======================================
+ Hits         5627     5628    +1     
  Misses       1787     1787           
Impacted Files Coverage Δ
deepmd/entrypoints/compress.py 76.78% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e321f...4ac0f5d. Read the comment docs.

Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I find a typo: updata -> update

@wanghan-iapcm wanghan-iapcm merged commit b9e51e8 into deepmodeling:devel Nov 21, 2021
@njzjz njzjz deleted the updata_deepmd_input branch March 8, 2022 18:43
@njzjz njzjz mentioned this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants