Fix bug with cudamemset's parameter #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## devel #1302 +/- ##
=======================================
Coverage 75.90% 75.90%
=======================================
Files 91 91
Lines 7417 7417
=======================================
Hits 5630 5630
Misses 1787 1787 Continue to review full report at Codecov.
|
|
It is an interesting bug, I agree with your fix. |
wanghan-iapcm
approved these changes
Nov 23, 2021
denghuilu
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cudaMemset and memset only accept integer type to fill the memory.
1.Alter template function: memset_device_memory
2.I notice there are many uses of memset or cudamemset use float type to fill the memory, but It is strange there isn't ant compile error....