Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix model compression bug when fparam or aparam is not zero #1306

Merged
merged 3 commits into from
Nov 23, 2021

Conversation

denghuilu
Copy link
Member

See also #1299

@wanghan-iapcm
Copy link
Collaborator

Please resolve the conflict

@codecov-commenter
Copy link

Codecov Report

Merging #1306 (83a106b) into devel (338ba31) will decrease coverage by 11.28%.
The diff coverage is n/a.

❗ Current head 83a106b differs from pull request most recent head 22f9d0d. Consider uploading reports for the commit 22f9d0d to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            devel    #1306       +/-   ##
===========================================
- Coverage   75.57%   64.28%   -11.29%     
===========================================
  Files          91        5       -86     
  Lines        7459       14     -7445     
===========================================
- Hits         5637        9     -5628     
+ Misses       1822        5     -1817     
Impacted Files Coverage Δ
deepmd/fit/ener.py
deepmd/train/trainer.py
deepmd/loss/__init__.py
deepmd/utils/argcheck.py
deepmd/utils/network.py
deepmd/descriptor/se_a.py
source/op/_soft_min_virial_grad.py
deepmd/model/ener.py
deepmd/entrypoints/__init__.py
deepmd/descriptor/se_a_ebd.py
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 338ba31...22f9d0d. Read the comment docs.

@wanghan-iapcm wanghan-iapcm enabled auto-merge (squash) November 23, 2021 01:21
@wanghan-iapcm wanghan-iapcm merged commit 843a3c5 into deepmodeling:devel Nov 23, 2021
@njzjz njzjz linked an issue Nov 23, 2021 that may be closed by this pull request
@njzjz njzjz mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] dp compress fail
3 participants