-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide an option to skip neighbor stat #1313
Conversation
Resolves deepmodeling#1088. Also fixes a bug in `update_sel`.
Codecov Report
@@ Coverage Diff @@
## devel #1313 +/- ##
===========================================
- Coverage 75.62% 64.28% -11.34%
===========================================
Files 91 5 -86
Lines 7494 14 -7480
===========================================
- Hits 5667 9 -5658
+ Misses 1827 5 -1822 Continue to review full report at Codecov.
|
Do we need to support the model compression workflow after skipping neighbor stat? For example, using training script as well as the training data to recompute the neighbor stat. |
We have already supported it... |
Oh, currently one needs to provide the script even if it has been stored |
If there's no neighbor stat in the original training process, the model compression will not be abled due to the lack of The calculation of nborstat is necessary, either during training or during model compression. |
deepmd-kit/deepmd/entrypoints/compress.py Line 88 in c8ded77
Isn't it? |
yes, no problem now |
The tests need to be fixed...
Resolves #1088.
Also fixes a bug in
update_sel
.