Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify C++ errors and pass message to LAMMPS #1326

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Dec 1, 2021

This commits unifies all C++ errors (including TF) into deepmd::deepmd_exception
and passes the error message to LAMMPS.

This commits unifies all C++ errors (including TF) to `deepmd::deepmd_exception`
and passes the error message to LAMMPS.
@codecov-commenter
Copy link

Codecov Report

Merging #1326 (bfe5960) into devel (67d3567) will decrease coverage by 11.29%.
The diff coverage is n/a.

❗ Current head bfe5960 differs from pull request most recent head 0955bc1. Consider uploading reports for the commit 0955bc1 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            devel    #1326       +/-   ##
===========================================
- Coverage   75.58%   64.28%   -11.30%     
===========================================
  Files          91        5       -86     
  Lines        7503       14     -7489     
===========================================
- Hits         5671        9     -5662     
+ Misses       1832        5     -1827     
Impacted Files Coverage Δ
deepmd/utils/learning_rate.py
deepmd/utils/neighbor_stat.py
deepmd/utils/network.py
deepmd/train/run_options.py
deepmd/fit/ener.py
deepmd/loss/__init__.py
deepmd/entrypoints/transfer.py
deepmd/entrypoints/freeze.py
deepmd/infer/deep_wfc.py
deepmd/entrypoints/doc.py
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d3567...0955bc1. Read the comment docs.

@wanghan-iapcm wanghan-iapcm merged commit bcd5a3b into deepmodeling:devel Dec 2, 2021
@njzjz njzjz deleted the error_cc branch December 21, 2021 23:39
njzjz pushed a commit to njzjz/deepmd-kit that referenced this pull request Sep 21, 2023
<!--pre-commit.ci start-->
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.0.286 →
v0.0.287](astral-sh/ruff-pre-commit@v0.0.286...v0.0.287)
<!--pre-commit.ci end-->

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants