only test/eval fitting properties #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During profiling, I found that the virial will be calculated even if I don't provide virial data. This is meaningless and the the viral has never been outputted. This commit removes such behavior. (cherry picked from commit 9a55069)
Codecov Report
@@ Coverage Diff @@
## devel #1416 +/- ##
==========================================
+ Coverage 74.42% 75.72% +1.30%
==========================================
Files 92 92
Lines 7507 7650 +143
==========================================
+ Hits 5587 5793 +206
+ Misses 1920 1857 -63
Continue to review full report at Codecov.
|
wanghan-iapcm
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During profiling, I found that the virial will be calculated in the test process even if I don't provide virial data.
This is meaningless and the viral has never been outputted.
This commit removes such behavior.
(cherry picked from commit 9a55069)