Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image link of ROCm version. #1432

Merged
merged 3 commits into from
Jan 22, 2022
Merged

Conversation

liangadam
Copy link
Contributor

No description provided.


To pull the ROCm version:
```bash
docker pull deepmodeling/dpmdkit-rocm:dp2.0.4-rocm4.5.2-tf2.6-lmp29Sep2021
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it dp2.0.4?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I‘m confused, too...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the source code you built from? setuptools-scm will bump a patch version if you do some change to a stable version, but you can use an environment variable to assign the version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It explains the matter~I have made some adjustments because the gelu gradient definition conflicts with TF 2.6.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also cmakefiles need to be modified on ROCm 3.5 or higher.

@njzjz njzjz changed the base branch from master to devel January 21, 2022 12:56
@njzjz
Copy link
Member

njzjz commented Jan 21, 2022

Also, the CI in the master branch is broken, so I changed the base branch to devel.

@wanghan-iapcm wanghan-iapcm merged commit 6238482 into deepmodeling:devel Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants