Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug of mixed precision training #1471

Merged
merged 6 commits into from
Feb 15, 2022

Conversation

denghuilu
Copy link
Member

#1469 should be fixed by this PR.

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2022

Codecov Report

Merging #1471 (22be0f5) into devel (82c787d) will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1471      +/-   ##
==========================================
+ Coverage   75.68%   75.98%   +0.29%     
==========================================
  Files          92       92              
  Lines        7671     7673       +2     
==========================================
+ Hits         5806     5830      +24     
+ Misses       1865     1843      -22     
Impacted Files Coverage Δ
deepmd/train/trainer.py 74.53% <100.00%> (+2.08%) ⬆️
deepmd/utils/network.py 92.63% <100.00%> (+9.83%) ⬆️
deepmd/descriptor/se_a.py 94.82% <0.00%> (+0.64%) ⬆️
deepmd/fit/ener.py 91.81% <0.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82c787d...22be0f5. Read the comment docs.

Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do wen have similar issues in other descriptors?

@denghuilu
Copy link
Member Author

Do wen have similar issues in other descriptors?

No, only se_a type support the mixed precision training.

deepmd/descriptor/se_a.py Outdated Show resolved Hide resolved
@njzjz njzjz linked an issue Feb 14, 2022 that may be closed by this pull request
@amcadmus amcadmus merged commit f015f58 into deepmodeling:devel Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Mixed precision training
5 participants