Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculate neighbor statistics from CLI #1476

Merged
merged 5 commits into from
Feb 17, 2022

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Feb 14, 2022

In many cases, we need to confirm neighbor statistics before training.
This command provides such CLI option.

In many cases, we need to confirm neighbor statistics before training.
This command provides such CLI option.
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2022

Codecov Report

Merging #1476 (c7ccc08) into devel (82c787d) will decrease coverage by 11.40%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##            devel    #1476       +/-   ##
===========================================
- Coverage   75.68%   64.28%   -11.41%     
===========================================
  Files          92        5       -87     
  Lines        7671       14     -7657     
===========================================
- Hits         5806        9     -5797     
+ Misses       1865        5     -1860     
Impacted Files Coverage Δ
deepmd/entrypoints/__init__.py
deepmd/entrypoints/main.py
deepmd/cluster/slurm.py
deepmd/descriptor/hybrid.py
deepmd/entrypoints/transfer.py
deepmd/train/trainer.py
source/op/_prod_force_se_r_grad.py
deepmd/infer/deep_tensor.py
deepmd/descriptor/se.py
deepmd/model/__init__.py
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82c787d...c7ccc08. Read the comment docs.

Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please:

  1. add to the document showing how it works.
  2. add a unittest for neighbor_stat
    Thanks!

Comment on lines +34 to +36
# set rcut to 0. will cause a core dumped
# TODO: check what is wrong
for rcut in (3., 6., 11.):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denghuilu setting rcut to 0. will cause "core dumped". Any ideas?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Although, I don't think some one will set it to 0)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be caused by this line:

ncell[dd] = to_face[dd] / rc;

Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghan-iapcm wanghan-iapcm merged commit 33a1dfa into deepmodeling:devel Feb 17, 2022
@njzjz njzjz deleted the neighbor_stat branch February 17, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants