recover input stats from frozen models #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, only NN parameters were recovered.
Codecov Report
@@ Coverage Diff @@
## devel #1482 +/- ##
==========================================
+ Coverage 75.99% 76.02% +0.02%
==========================================
Files 93 93
Lines 7674 7711 +37
==========================================
+ Hits 5832 5862 +30
- Misses 1842 1849 +7
Continue to review full report at Codecov.
|
denghuilu
approved these changes
Feb 18, 2022
wanghan-iapcm
approved these changes
Feb 19, 2022
njzjz
commented
Mar 14, 2022
| The suffix of the scope | ||
| """ | ||
| self.davg = get_tensor_by_name(model_file, 'descrpt_attr%s/t_avg' % suffix) | ||
| self.tavg = get_tensor_by_name(model_file, 'descrpt_attr%s/t_std' % suffix) |
There was a problem hiding this comment.
I found I made a typo here
tavg -> dstd
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Mar 14, 2022
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Mar 14, 2022
commit 12e224b Author: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Date: Mon Mar 14 18:17:20 2022 -0400 adjust variable name commit 6ac8207 Author: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Date: Mon Mar 14 17:58:29 2022 -0400 add unittests commit 1dcc218 Author: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Date: Mon Mar 14 17:38:02 2022 -0400 supports increasing sel commit 1f1fcda Merge: 58a5dfd d8a0844 Author: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Date: Mon Mar 14 17:01:41 2022 -0400 Merge branch 'devel' into adjust_sel commit 58a5dfd Author: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Date: Mon Mar 14 17:01:14 2022 -0400 support recovering sel<original_sel commit a6ee102 Author: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Date: Mon Mar 14 16:25:55 2022 -0400 fix a typo in deepmodeling#1482 commit 65dd1ab Author: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Date: Mon Mar 14 02:18:53 2022 -0400 save checkpoints after training if it's not saved
| @@ -106,6 +106,8 @@ def init_variables(self, | |||
| The suffix of the scope | |||
| """ | |||
| self.embedding_net_variables = get_embedding_net_variables(model_file, suffix = suffix) | |||
| self.davg = get_tensor_by_name(model_file, 'descrpt_attr%s/t_avg' % suffix) | |||
| self.tavg = get_tensor_by_name(model_file, 'descrpt_attr%s/t_std' % suffix) | |||
There was a problem hiding this comment.
Same typo introduced here....
wanghan-iapcm
pushed a commit
that referenced
this pull request
Mar 15, 2022
* save checkpoints after training if it's not saved * fix a typo in #1482 * support recovering sel<original_sel * supports increasing sel * add unittests * adjust variable name * add doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, only NN parameters were recovered.