Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dp mask pb size and fix bug in dim_fparam/dim_aparam fetching #2588

Merged
merged 20 commits into from Jun 5, 2023

Conversation

dingye18
Copy link
Contributor

@dingye18 dingye18 commented Jun 5, 2023

No description provided.

@wanghan-iapcm wanghan-iapcm requested a review from njzjz June 5, 2023 03:45
source/api_c/src/c_api.cc Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (48bcd13) 76.67% compared to head (80a32c2) 76.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2588      +/-   ##
==========================================
- Coverage   76.67%   76.66%   -0.01%     
==========================================
  Files         233      233              
  Lines       24175    24175              
  Branches     1711     1711              
==========================================
- Hits        18536    18534       -2     
  Misses       4518     4518              
- Partials     1121     1123       +2     
Impacted Files Coverage Δ
source/api_c/src/c_api.cc 76.48% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wanghan-iapcm wanghan-iapcm enabled auto-merge (squash) June 5, 2023 04:53
auto-merge was automatically disabled June 5, 2023 08:58

Head branch was pushed to by a user without write access

@njzjz njzjz merged commit 77596f8 into deepmodeling:devel Jun 5, 2023
38 checks passed
@dingye18 dingye18 deleted the reduce_dp_mask_pb_size branch June 6, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants