Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory leaking in test_env_mat_a_mix.cc #2596

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jun 6, 2023

new[] should be used with delete[].

`new[]` should be used with `del[]`.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz marked this pull request as ready for review June 6, 2023 20:04
@njzjz njzjz requested a review from iProzd June 6, 2023 20:04
@github-actions github-actions bot added the Core label Jun 6, 2023
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (a3c8980) 76.64% compared to head (134c805) 76.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2596      +/-   ##
==========================================
+ Coverage   76.64%   76.66%   +0.02%     
==========================================
  Files         233      233              
  Lines       24177    24177              
  Branches     1711     1711              
==========================================
+ Hits        18530    18536       +6     
+ Misses       4525     4518       -7     
- Partials     1122     1123       +1     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@wanghan-iapcm wanghan-iapcm merged commit 4b822b8 into deepmodeling:devel Jun 7, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants