New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support generalized force loss #2690
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #2690 +/- ##
==========================================
+ Coverage 78.17% 78.69% +0.51%
==========================================
Files 238 239 +1
Lines 24859 25549 +690
Branches 1509 1517 +8
==========================================
+ Hits 19433 20105 +672
- Misses 5034 5054 +20
+ Partials 392 390 -2
☔ View full report in Codecov by Sentry. |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I am not sure how would it be useful in practice, because a low normal force loss would naturally lead to a low generalized force loss if dr/dq is not degenerate.
This is Tim's idea. Here is my understanding. In umbrella sampling free energy calculation, the only quantity from simulations directly used to calculate free energy is the reaction coordinates (we make it the generalized coordinates
I agree it has been low (the papers I published have proved it), but what we expect is that generalized force has even better accuracy than before, without significantly decreasing the accuracy of the normal force. |
Clear, Thanks! |
Support the loss for generalized forces. Tests and examples have been added.
Generalized forces are given by
The loss for generalized forces is given by
In the example, the generalized coordinates$q$ are the restraint coordinates in the enhanced sampling.
This PR also improves documentation for other arguments in the loss.