symlink model.ckpt.* to relative paths
#2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, `ckpt_prefix` is an absolute path and the generated symilnks link to an abosulote path. If users wants to move the whole directory, the relative path should be more user-friendly. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
This reverts commit 611770b.
Before, `model.ckpt.*` is symilnks to an abosulote path. If users wants to move the whole directory, the relative path will be more user-friendly. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #2720 +/- ##
=======================================
Coverage 78.64% 78.65%
=======================================
Files 239 239
Lines 25465 25465
Branches 1517 1517
=======================================
+ Hits 20028 20030 +2
Misses 5045 5045
+ Partials 392 390 -2
☔ View full report in Codecov by Sentry. |
wanghan-iapcm
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before,
model.ckpt.*is symilnks to an abosulote path. If users wants to move the whole directory, the relative path will be more user-friendly.