Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve configurations of Python lint tools #2823

Merged
merged 5 commits into from Sep 15, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Sep 15, 2023

  1. use black-pre-commit-mirror instead of black which is faster;
  2. first ruff and then black;
  3. remove tool.ruff.target-version which can be detected automatically;
  4. add RUF and NPY rules to tool.ruff.select;
  5. set tool.ruff.pydocstyle.convention to numpy, which can automatically add several rules to ignore.

njzjz and others added 5 commits September 12, 2023 09:29
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz marked this pull request as draft September 15, 2023 04:09
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 86.95% and no project coverage change.

Comparison is base (1a4a7ca) 75.49% compared to head (c6a79aa) 75.49%.
Report is 1 commits behind head on devel.

❗ Current head c6a79aa differs from pull request most recent head f51b9df. Consider uploading reports for the commit f51b9df to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #2823   +/-   ##
=======================================
  Coverage   75.49%   75.49%           
=======================================
  Files         242      242           
  Lines       24163    24163           
  Branches     1533     1533           
=======================================
  Hits        18241    18241           
  Misses       5006     5006           
  Partials      916      916           
Files Changed Coverage Δ
deepmd/calculator.py 80.55% <ø> (ø)
deepmd/entrypoints/ipi.py 0.00% <0.00%> (ø)
deepmd/fit/dos.py 48.40% <ø> (ø)
deepmd/loss/ener.py 68.23% <ø> (ø)
deepmd/utils/data_system.py 84.00% <0.00%> (ø)
deepmd/utils/path.py 91.45% <0.00%> (ø)
deepmd/utils/spin.py 86.36% <ø> (ø)
deepmd/descriptor/se_a.py 95.72% <100.00%> (ø)
deepmd/descriptor/se_a_ebd.py 67.13% <100.00%> (ø)
deepmd/descriptor/se_atten.py 93.97% <100.00%> (ø)
... and 10 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz marked this pull request as ready for review September 15, 2023 04:26
@wanghan-iapcm wanghan-iapcm enabled auto-merge (squash) September 15, 2023 05:09
@wanghan-iapcm wanghan-iapcm merged commit 21db464 into deepmodeling:devel Sep 15, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants