download cub using CMake FetchContent #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many people suggests not using git submodule. CMake FetchContent might be a better option (which has been used by us for googletest and lammps). (only take effect for CUDA 10; CUDA 11 contains cub) Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #2870 +/- ##
=======================================
Coverage 75.38% 75.38%
=======================================
Files 242 242
Lines 24424 24424
Branches 1580 1580
=======================================
Hits 18411 18411
Misses 5082 5082
Partials 931 931 ☔ View full report in Codecov by Sentry. |
wanghan-iapcm
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many people suggest not using
git submodule. CMake FetchContent might be a better option (which we have used for googletest and lammps).(only take effect for CUDA 10; CUDA 11 contains cub)