cc: fix returning type of sel_types #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the following compiler warning:
```
/home/runner/work/deepmd-kit/deepmd-kit/source/api_c/src/c_api.cc:1336:17: warning: returning address of local temporary object [-Wreturn-stack-address]
return (int*)&(dcm->dcm.sel_types())[0];
^~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
by returning the reference of sel_type.
It seems this function is not used anywhere, even in the test, so we don't have an chance to find out if there is possible segfault. (so this warning has no impact)
It seems DeepTensor has returned a reference since the beginning (deepmodeling#137). (perhaps because DeepTensor.sel_types is actually used) DeepTensor and DataChargeModifier have different returned types.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3181 +/- ##
=======================================
Coverage 76.08% 76.08%
=======================================
Files 284 284
Lines 25699 25699
Branches 1592 1592
=======================================
Hits 19552 19552
Misses 5222 5222
Partials 925 925 ☔ View full report in Codecov by Sentry. |
wanghan-iapcm
approved these changes
Jan 27, 2024
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Feb 4, 2024
Fix the following compiler warning:
```
/home/runner/work/deepmd-kit/deepmd-kit/source/api_c/src/c_api.cc:1336:17: warning: returning address of local temporary object [-Wreturn-stack-address]
return (int*)&(dcm->dcm.sel_types())[0];
^~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
by returning the reference of `sel_type`.
`DataChargeModifier.sel_types` is not used anywhere, even in the test,
so we don't have a chance to determine if there is a possible segfault,
and this warning has no actual impact.
It seems `DeepTensor` has returned a reference since the beginning
(deepmodeling#137). (perhaps because
`DeepTensor.sel_types` is used) `DeepTensor` and `DataChargeModifier`
have different returned types.
(cherry picked from commit f900f3a)
wanghan-iapcm
pushed a commit
that referenced
this pull request
Feb 4, 2024
Fix the following compiler warning:
```
/home/runner/work/deepmd-kit/deepmd-kit/source/api_c/src/c_api.cc:1336:17: warning: returning address of local temporary object [-Wreturn-stack-address]
return (int*)&(dcm->dcm.sel_types())[0];
^~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
by returning the reference of `sel_type`.
`DataChargeModifier.sel_types` is not used anywhere, even in the test,
so we don't have a chance to determine if there is a possible segfault,
and this warning has no actual impact.
It seems `DeepTensor` has returned a reference since the beginning
(#137). (perhaps because
`DeepTensor.sel_types` is used) `DeepTensor` and `DataChargeModifier`
have different returned types.
(cherry picked from commit f900f3a)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following compiler warning:
by returning the reference of
sel_type.DataChargeModifier.sel_typesis not used anywhere, even in the test, so we don't have a chance to determine if there is a possible segfault, and this warning has no actual impact.It seems
DeepTensorhas returned a reference since the beginning (#137). (perhaps becauseDeepTensor.sel_typesis used)DeepTensorandDataChargeModifierhave different returned types.