merge compute_output_stat #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3310 +/- ##
==========================================
- Coverage 75.83% 75.77% -0.06%
==========================================
Files 415 382 -33
Lines 34862 30121 -4741
Branches 1614 909 -705
==========================================
- Hits 26437 22824 -3613
+ Misses 7557 6769 -788
+ Partials 868 528 -340 ☔ View full report in Codecov by Sentry. |
I would propose compute the avg (like the atom_bias_e) and std of label. By far we remove the avg, it is also possible to scale the output of the fitting net by the std. The polar of the TF uses the statistics of the diagonal of the avg. |
|
I realize that the std for each type is not available. We may need to uniformly scale the atomic output based on statistics. |
wanghan-iapcm
requested changes
Feb 21, 2024
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
wanghan-iapcm
requested changes
Feb 28, 2024
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
wanghan-iapcm
approved these changes
Feb 28, 2024
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
iProzd
approved these changes
Feb 28, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.