Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tf): fix bugs in tensor training and migrate to reformat data #3581

Merged
merged 3 commits into from Mar 25, 2024
Merged

fix(tf): fix bugs in tensor training and migrate to reformat data #3581

merged 3 commits into from Mar 25, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Mar 21, 2024

Fix #3499.

@njzjz
fix(tf): fix several bugs in tensor training and migrate to the refor…
eb678fb 
…mat data

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz linked an issue Mar 21, 2024 that may be closed by this pull request
[Feature Request] example: use the new format for dipole/polar #3499
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 21, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.70%. Comparing base (fb61efb) to head (5601432).
Report is 4 commits behind head on devel.

Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #3581      +/-   ##
==========================================
+ Coverage   77.54%   77.70%   +0.16%     
==========================================
  Files         432      432              
  Lines       37183    37357     +174     
  Branches     1620     1620              
==========================================
+ Hits        28832    29030     +198     
+ Misses       7490     7466      -24     
  Partials      861      861

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz marked this pull request as draft March 22, 2024 00:29
@njzjz
add ut for data stat
7cd950a 
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz marked this pull request as ready for review March 22, 2024 00:44
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 22, 2024
View reviewed changes
source/tests/tf/test_polar_se_a.py Fixed Show resolved Hide resolved
source/tests/tf/test_polar_se_a.py Fixed Show resolved Hide resolved
@njzjz
Remove unnecessay assignments
5601432 
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz added this pull request to the merge queue Mar 25, 2024
Merged via the queue into deepmodeling:devel with commit 3c3e2ce Mar 25, 2024
48 checks passed
@njzjz njzjz deleted the tf-tensor-training branch March 25, 2024 18:42
@njzjz njzjz mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iProzd iProzd iProzd approved these changes

@wanghan-iapcm wanghan-iapcm wanghan-iapcm approved these changes

Assignees
No one assigned
Labels
Examples Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] example: use the new format for dipole/polar
3 participants
@njzjz @iProzd @wanghan-iapcm