Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt: fix redundant size assert #3740

Merged
merged 1 commit into from
May 5, 2024
Merged

Conversation

CaRoLZhangxy
Copy link
Collaborator

@CaRoLZhangxy CaRoLZhangxy commented May 5, 2024

#3738

Summary by CodeRabbit

  • Refactor
    • Improved the efficiency of computation by removing unnecessary checks.

@CaRoLZhangxy CaRoLZhangxy requested a review from njzjz May 5, 2024 10:53
@github-actions github-actions bot added the LAMMPS label May 5, 2024
Copy link

coderabbitai bot commented May 5, 2024

Walkthrough

Walkthrough

The update involves a modification in the PairDeepMD::compute method, where a specific assertion related to the size of MPI_Comm has been removed. This change potentially affects how the method handles MPI communication contexts.

Changes

File Change Summary
.../pair_deepmd.cpp Removed assertion checking the size of MPI_Comm.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 0ba7e6a and b21fd63.
Files selected for processing (1)
  • source/lmp/pair_deepmd.cpp (1 hunks)
Files skipped from review due to trivial changes (1)
  • source/lmp/pair_deepmd.cpp

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.19%. Comparing base (0ba7e6a) to head (b21fd63).

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3740   +/-   ##
=======================================
  Coverage   82.19%   82.19%           
=======================================
  Files         513      513           
  Lines       47642    47642           
  Branches     2983     2980    -3     
=======================================
  Hits        39159    39159           
  Misses       7572     7572           
  Partials      911      911           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz linked an issue May 5, 2024 that may be closed by this pull request
@njzjz njzjz added this pull request to the merge queue May 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 5, 2024
@njzjz njzjz added this pull request to the merge queue May 5, 2024
Merged via the queue into deepmodeling:devel with commit 2be5f0f May 5, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] _Error with Pytorch models
2 participants