Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(python): enable building PT OP #3787

Merged
merged 3 commits into from
May 16, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented May 15, 2024

This enables building PyTorch customized OP in the Python tests for future usage. PyTorch provides undocumented cxx11 CPU-only wheels at https://download.pytorch.org/whl/torch_stable.html.

Summary by CodeRabbit

  • Chores
    • Updated package installation commands for mpich and torch in the testing workflow.
    • Set PYTORCH_ROOT environment variable.
    • Added DP_ENABLE_PYTORCH environment variable.

njzjz added 3 commits May 15, 2024 02:56
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz requested a review from wanghan-iapcm May 15, 2024 08:11
Copy link

coderabbitai bot commented May 15, 2024

Walkthrough

Walkthrough

The updates to the .github/workflows/test_python.yml file primarily focus on modifying the package installation commands to ensure compatibility with specific versions of mpich and torch. Additionally, environment variables such as PYTORCH_ROOT and DP_ENABLE_PYTORCH are set to configure the testing environment appropriately. These changes aim to streamline the setup process and enhance the integration of PyTorch within the testing workflow.

Changes

File Change Summary
.github/workflows/test_python.yml Updated package installation commands for mpich and torch, set PYTORCH_ROOT, added DP_ENABLE_PYTORCH.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 2bf0769 and d39e20f.
Files selected for processing (1)
  • .github/workflows/test_python.yml (1 hunks)
Additional comments not posted (4)
.github/workflows/test_python.yml (4)

27-27: The installation command for mpich looks good.


28-29: The installation command for torch with a specific version and ABI looks good.


30-30: The command to set the PYTORCH_ROOT environment variable looks good.


31-38: The modified uv pip install command and the addition of the DP_ENABLE_PYTORCH environment variable look good.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.47%. Comparing base (2bf0769) to head (d39e20f).

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3787      +/-   ##
==========================================
- Coverage   82.49%   82.47%   -0.02%     
==========================================
  Files         515      515              
  Lines       48642    48642              
  Branches     2980     2979       -1     
==========================================
- Hits        40126    40117       -9     
- Misses       7605     7614       +9     
  Partials      911      911              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue May 16, 2024
Merged via the queue into deepmodeling:devel with commit d0d596b May 16, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants