Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for n2p2 data format #627

Merged
merged 15 commits into from
Apr 3, 2024
Merged

Conversation

Yi-FanLi
Copy link
Collaborator

@Yi-FanLi Yi-FanLi commented Apr 2, 2024

No description provided.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.08%. Comparing base (18a0ed5) to head (cfb6d7d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
+ Coverage   82.81%   83.08%   +0.27%     
==========================================
  Files          73       74       +1     
  Lines        6580     6686     +106     
==========================================
+ Hits         5449     5555     +106     
  Misses       1131     1131              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a test?

dpdata/plugins/np2p.py Outdated Show resolved Hide resolved
@Yi-FanLi
Copy link
Collaborator Author

Yi-FanLi commented Apr 2, 2024

could you add a test?

added by commit 506b187

@Yi-FanLi Yi-FanLi requested a review from njzjz April 2, 2024 22:36
Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@wanghan-iapcm wanghan-iapcm merged commit e2f235f into deepmodeling:master Apr 3, 2024
9 checks passed
@wanghan-iapcm
Copy link
Contributor

@njzjz i merged it to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants