Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] cannot find upload file due to the conflict between pr#1127 and dpdispatcher #1192

Closed
scott-5 opened this issue Apr 23, 2023 · 3 comments · Fixed by #1214
Closed

[BUG] cannot find upload file due to the conflict between pr#1127 and dpdispatcher #1192

scott-5 opened this issue Apr 23, 2023 · 3 comments · Fixed by #1214
Assignees
Labels
bug Something isn't working

Comments

@scott-5
Copy link

scott-5 commented Apr 23, 2023

Summary

If the number of elements of the structure in sys_configs is less than type_map ( for example, exploring the single component A in the alloy ABC ), it will report pp file of B and C cannot be uploaded. It seems that this pr #1127 makes dpgen only copy the pp and orb of the elements required by the structure in sys_configs, but the dpdispatcher is uploaded following all the elements in param.json.

DPGEN Version and software of FP

The version of DPGEN is 0.11.1 which is combined with ABACUS.

Expected Behavior

Traceback (most recent call last):
  File "/home/user/anaconda3/envs/dpgen/bin/dpgen", line 10, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/user/anaconda3/envs/dpgen/lib/python3.11/site-packages/dpgen/main.py", line 233, in main
    args.func(args)
  File "/home/user/anaconda3/envs/dpgen/lib/python3.11/site-packages/dpgen/generator/run.py", line 5109, in gen_run
    run_iter(args.PARAM, args.MACHINE)
  File "/home/user/anaconda3/envs/dpgen/lib/python3.11/site-packages/dpgen/generator/run.py", line 4461, in run_iter
    run_fp(ii, jdata, mdata)
  File "/home/user/anaconda3/envs/dpgen/lib/python3.11/site-packages/dpgen/generator/run.py", line 3765, in run_fp
    run_fp_inner(
  File "/home/user/anaconda3/envs/dpgen/lib/python3.11/site-packages/dpgen/generator/run.py", line 3702, in run_fp_inner
    submission.run_submission()
  File "/home/user/anaconda3/envs/dpgen/lib/python3.11/site-packages/dpdispatcher/submission.py", line 219, in run_submission
    self.upload_jobs()
  File "/home/user/anaconda3/envs/dpgen/lib/python3.11/site-packages/dpdispatcher/submission.py", line 421, in upload_jobs
    self.machine.context.upload(self)
  File "/home/user/anaconda3/envs/dpgen/lib/python3.11/site-packages/dpdispatcher/ssh_context.py", line 570, in upload
    self._walk_directory(
  File "/home/user/anaconda3/envs/dpgen/lib/python3.11/site-packages/dpdispatcher/ssh_context.py", line 543, in _walk_directory
    raise RuntimeError(f"cannot find upload file {work_path} {jj}")
RuntimeError: cannot find upload file /home/user/colombo-ABACUS/run/iter.000001/02.fp/task.000.000000 Zn_ONCV_PBE-1.0.upf

Steps to Reproduce

This bug is easy to reproduce by the example with little modifications for adding an additional element such as Zn.

@scott-5 scott-5 added the bug Something isn't working label Apr 23, 2023
@pxlxingliang
Copy link
Contributor

Hi @scott-5, this is really strange. PR #1127 is originally used to support the scenes you mentioned. In my server, I cannot reproduce this bug, can you provide me with the input files?

@pxlxingliang
Copy link
Contributor

@scott-5 You are right, I have identified the problem codes. I will fix it latter.

@scott-5
Copy link
Author

scott-5 commented May 9, 2023

Thank you. Roughly tested with the commit codes, the problem is solved. Expecting codes to be merged !

@njzjz njzjz linked a pull request May 9, 2023 that will close this issue
wanghan-iapcm pushed a commit that referenced this issue May 16, 2023
#1192

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz closed this as completed May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants