Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support mixed:N batch size #1183

Merged
merged 3 commits into from Apr 17, 2023
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Apr 13, 2023

This allows setting batches of mixed systems, i.e. mixed:N, without being overridden by DP-GEN.

P.S. now mixed:N does work in my systems.

This allows setting batches of mixed systems, i.e. `mixed:N`.
@njzjz njzjz changed the title do not override the batch size when it has been given support mixed batch size Apr 13, 2023
@njzjz njzjz changed the title support mixed batch size support mixed:N batch size Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.01 ⚠️

Comparison is base (e500bd7) 46.57% compared to head (899f0e9) 46.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1183      +/-   ##
==========================================
- Coverage   46.57%   46.57%   -0.01%     
==========================================
  Files          82       82              
  Lines       14591    14593       +2     
==========================================
  Hits         6796     6796              
- Misses       7795     7797       +2     
Impacted Files Coverage Δ
dpgen/generator/run.py 65.92% <0.00%> (-0.05%) ⬇️
dpgen/generator/arginfo.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wanghan-iapcm wanghan-iapcm merged commit fd9b9d2 into deepmodeling:devel Apr 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants