Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify: do not symlink if the file does not exist #1191

Merged
merged 3 commits into from May 4, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Apr 20, 2023

If there is no candidate (i.e. all accurate or all failed), picked_data_path will not be dumped.

If there is no candidate (i.e. all accurate or all failed), `picked_data_path` will not be dumped.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (6c06107) 47.07% compared to head (6e9ca07) 47.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1191      +/-   ##
==========================================
+ Coverage   47.07%   47.09%   +0.01%     
==========================================
  Files          82       82              
  Lines       14598    14609      +11     
==========================================
+ Hits         6872     6880       +8     
- Misses       7726     7729       +3     
Impacted Files Coverage Δ
dpgen/simplify/simplify.py 21.11% <0.00%> (-0.18%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wanghan-iapcm wanghan-iapcm merged commit d8519df into deepmodeling:devel May 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants