Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend the doc of cp2k external_input_path in detail #1225

Merged
merged 9 commits into from May 30, 2023
Merged

extend the doc of cp2k external_input_path in detail #1225

merged 9 commits into from May 30, 2023

Conversation

robinzyb
Copy link
Collaborator

How to add code blocks in the doc?

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e68580c) 47.22% compared to head (e024f03) 47.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #1225   +/-   ##
=======================================
  Coverage   47.22%   47.22%           
=======================================
  Files          82       82           
  Lines       14666    14666           
=======================================
  Hits         6926     6926           
  Misses       7740     7740           
Impacted Files Coverage Δ
dpgen/generator/arginfo.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@njzjz
Copy link
Member

njzjz commented May 22, 2023

How to add code blocks in the doc?

It's generated in the RST file so that you can follow the RST grammar. https://devguide.python.org/documentation/markup/

@robinzyb
Copy link
Collaborator Author

why did CI fail at TypeError: issubclass() arg 1 must be a class ? I make no change on this part of test code

@njzjz
Copy link
Member

njzjz commented May 23, 2023

why did CI fail at TypeError: issubclass() arg 1 must be a class ? I make no change on this part of test code

I can reproduce the error in a clean python 3.8 image.

@njzjz
Copy link
Member

njzjz commented May 23, 2023

I submit materialsproject/api#809 to pymatgen and hope this issue can be resolved as soon as possible.

@wanghan-iapcm wanghan-iapcm merged commit 0cd4e7c into deepmodeling:devel May 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants