Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop Python 3.8 support #1264

Merged
merged 4 commits into from Jul 5, 2023
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jul 5, 2023

The upstream package has a bug in Python 3.8 (materialsproject/api#809), so we decide to drop Python 3.8 support.

njzjz and others added 4 commits July 4, 2023 21:32
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07 ⚠️

Comparison is base (0b8b175) 47.86% compared to head (7e4f5a4) 47.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1264      +/-   ##
==========================================
- Coverage   47.86%   47.79%   -0.07%     
==========================================
  Files          82       82              
  Lines       14558    14586      +28     
==========================================
+ Hits         6968     6972       +4     
- Misses       7590     7614      +24     
Impacted Files Coverage Δ
dpgen/generator/run.py 66.56% <ø> (-0.02%) ⬇️
dpgen/arginfo.py 92.59% <100.00%> (ø)
dpgen/data/arginfo.py 96.29% <100.00%> (-0.05%) ⬇️
dpgen/dispatcher/Dispatcher.py 83.78% <100.00%> (-0.43%) ⬇️
dpgen/generator/arginfo.py 100.00% <100.00%> (ø)
dpgen/simplify/arginfo.py 100.00% <100.00%> (ø)
dpgen/simplify/simplify.py 22.18% <100.00%> (ø)
dpgen/util.py 94.62% <100.00%> (+0.05%) ⬆️

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wanghan-iapcm wanghan-iapcm merged commit 997b99d into deepmodeling:devel Jul 5, 2023
7 checks passed
kaiqi-wang pushed a commit to kaiqi-wang/dpgen that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants