Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autotest: fix early return and result checking #574

Merged
merged 1 commit into from Oct 15, 2021
Merged

autotest: fix early return and result checking #574

merged 1 commit into from Oct 15, 2021

Conversation

shazj99
Copy link
Contributor

@shazj99 shazj99 commented Oct 14, 2021

There're two issues in run_property():

  1. If there is not task to be run for a property(may have already been done in last run), we should skip it and run other properties instead of return.
  2. All the results had better to be checked instead of only the last one.

Change-Id: I4430b2c2e20da6cb28640dbc6139e62bed5357a2

autotest: fix early return and result checking
b8a9262 
Change-Id: I4430b2c2e20da6cb28640dbc6139e62bed5357a2
@wanghan-iapcm wanghan-iapcm merged commit f0d0701 into deepmodeling:devel Oct 15, 2021
Cloudac7 pushed a commit to Cloudac7/dpgen that referenced this pull request Dec 1, 2021
@shazj99 @Cloudac7
autotest: fix early return and result checking (deepmodeling#574)
0b15102 
Change-Id: I4430b2c2e20da6cb28640dbc6139e62bed5357a2

Co-authored-by: Zhengju Sha <jenny@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinwenminion kevinwenminion kevinwenminion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shazj99 @kevinwenminion @wanghan-iapcm