-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug of fp_task_min #596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea of fp_task_min
is not to skip fp calculations when the number of fp jobs is too small, but to skip the training in the next iteration if the number of new fp jobs is too small. In this case, the fp tasks are labeled, and the labels are stored for future trainings.
Dear Teacher Wang, |
The current documentation needs to be corrected. See also deepmodeling#596.
The current documentation needs to be corrected. See also #596. --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Co-authored-by: Han Wang <92130845+wanghan-iapcm@users.noreply.github.com>
Currently fp_task_min doesn't work.
The reason is
task_min
is set to -1 and passed to https://github.com/deepmodeling/dpgen/blame/v0.10.2/dpgen/generator/run.py#L1538 .