Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug of fp_task_min #596

Closed
wants to merge 11 commits into from
Closed

Conversation

AnguseZhang
Copy link
Collaborator

Currently fp_task_min doesn't work.
The reason is task_min is set to -1 and passed to https://github.com/deepmodeling/dpgen/blame/v0.10.2/dpgen/generator/run.py#L1538 .

Copy link
Contributor

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea of fp_task_min is not to skip fp calculations when the number of fp jobs is too small, but to skip the training in the next iteration if the number of new fp jobs is too small. In this case, the fp tasks are labeled, and the labels are stored for future trainings.

@AnguseZhang AnguseZhang closed this Dec 2, 2021
@lauthirteen
Copy link

The idea of fp_task_min is not to skip fp calculations when the number of fp jobs is too small, but to skip the training in the next iteration if the number of new fp jobs is too small. In this case, the fp tasks are labeled, and the labels are stored for future trainings.

Dear Teacher Wang,
If the number of fp jobs is too small in this fp calculation, and it is not added in all subsequent iterations? Or, what does the "future trainings" mean here ?

njzjz added a commit to njzjz/dpgen that referenced this pull request Jun 23, 2023
The current documentation needs to be corrected. See also deepmodeling#596.
wanghan-iapcm added a commit that referenced this pull request Jun 25, 2023
The current documentation needs to be corrected. See also #596.

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: Han Wang <92130845+wanghan-iapcm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants