-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gromacswrapper to conda recipe #615
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #615 +/- ##
=======================================
Coverage 35.12% 35.12%
=======================================
Files 96 96
Lines 16793 16793
=======================================
Hits 5898 5898
Misses 10895 10895 Continue to review full report at Codecov.
|
conda/gromacswrapper/meta.yaml
Outdated
- python | ||
run: | ||
- matplotlib-base | ||
- numkit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package is not available yet.
I think you can submit to https://github.com/conda-forge/staged-recipes instead? We do not need to maintain every package by ourselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you.
We can submit the recipes to conda-forge
. But I found some PRs have been in progressing for a long time before they can be merged into conda-forge
, so I also submitted numkit recipe, which can solve the problem currently. @felix5572 Maybe would you like to join this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, I don't think it needs to be summited to DP-GEN's repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@njzjz We decide to publish 0.10.4
version tomorrow, and I haven't submitted the recipes to conda-forge
yet. But I still hope to merge this PR first to let offline package be available for the community. What's your opinion ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to publish packages to our channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A problem here is that we need to build the dependencies and upload to deepmodeling's channel. However, adding them here won't build and upload automatically, so I do not see the meaning of this PR.
These two recipes are added to
This PR could be closed. |
netCDF4's dependency should be added. https://github.com/deepmodeling/dpgen/pull/792/files |
No description provided.