Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add simplify jdata docs; fix and check example #787

Merged
merged 8 commits into from Jul 9, 2022
Merged

add simplify jdata docs; fix and check example #787

merged 8 commits into from Jul 9, 2022

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jul 7, 2022 •
edited

Fix #779.

@njzjz njzjz changed the base branch from master to devel July 7, 2022 22:19
@njzjz njzjz linked an issue Jul 7, 2022 that may be closed by this pull request
add arguments and docs for simplify #779
Closed
@njzjz njzjz added the documentation Improvements or additions to documentation label Jul 7, 2022
@njzjz njzjz changed the title simplify jdata docs add simplify jdata docs; fix and check example Jul 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022 •
edited

Codecov Report

Merging #787 (3c70c8b) into devel (adb261d) will increase coverage by 0.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            devel     #787      +/-   ##
==========================================
+ Coverage   34.72%   35.11%   +0.39%     
==========================================
  Files          96       96              
  Lines       16771    16794      +23     
==========================================
+ Hits         5823     5898      +75     
+ Misses      10948    10896      -52
Impacted Files Coverage Δ
dpgen/generator/arginfo.py 47.11% <100.00%> (+47.11%) ⬆️
dpgen/simplify/arginfo.py 96.29% <100.00%> (+96.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adb261d...3c70c8b. Read the comment docs.

@njzjz
Copy link
Member Author

njzjz commented Jul 7, 2022

https://deepmodeling--787.org.readthedocs.build/projects/dpgen/en/787/simplify/simplify-jdata.html

@AnguseZhang AnguseZhang merged commit 32a9996 into deepmodeling:devel Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuangJiameng HuangJiameng HuangJiameng approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Add docs for DP-GEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add arguments and docs for simplify
4 participants
@njzjz @codecov-commenter @HuangJiameng @AnguseZhang