-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support forward files for init_surf #909
Support forward files for init_surf #909
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #909 +/- ##
==========================================
+ Coverage 38.14% 38.23% +0.08%
==========================================
Files 99 99
Lines 17766 17803 +37
==========================================
+ Hits 6777 6807 +30
- Misses 10989 10996 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Isn't it |
It is |
I think it's this feature: Lines 580 to 582 in 5dc7c1b
Indeed we should not maintain it everywhere... Create a method instead. |
In contrast, I think it is more reasonable to put symlinks in the task path for paths in "forward_files". Otherwise the user should pile everything in the main directory. Besides, should we keep the same parameter name "forward_files" with dpdispatcher? |
I don't understand what you mean. The old codes also make symbolic links. Making an alias is fine, but the old name should be kept for compatibility. |
work_path_list = glob.glob(os.path.join(work_dir, "surf-*")) | ||
task_format = {"fp" : "sys-*"} | ||
for work_path in work_path_list : | ||
symlink_user_forward_files(mdata=mdata, task_type="fp", work_path=work_path, task_format=task_format) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not directly set the format as surf-*/sys-*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because surf-*
seems to align with the meaning of work_path
.
Since "forward_files" for init_surf is supported (see #909), here add the relevant doc.
Support user use "forward_files" in machine parameters to upload other files besides POSCAR, INCAR, POTCAR. (forwarded files for each task)