Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support no pbc calculation #104

Merged
merged 1 commit into from
Dec 25, 2022
Merged

Conversation

wanghan-iapcm
Copy link

This PR introduces the changes:

  • support the remove_pbc option in the FileConfGenerator (input confs for exploreation)
  • support removing the pbc from the selected configurations. (output confs from exploration for fp calculations)
  • supply training input template rather than writing it in the dpgen input script.
  • fix bugs in gaussian support (args claim does not match interface)

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2022

Codecov Report

Base: 81.14% // Head: 81.05% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (196a5f0) compared to base (c4acd0b).
Patch coverage: 62.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   81.14%   81.05%   -0.09%     
==========================================
  Files          69       69              
  Lines        2874     2887      +13     
==========================================
+ Hits         2332     2340       +8     
- Misses        542      547       +5     
Impacted Files Coverage Δ
dpgen2/entrypoint/submit.py 16.75% <0.00%> (-0.36%) ⬇️
dpgen2/conf/file_conf.py 97.29% <83.33%> (-2.71%) ⬇️
dpgen2/entrypoint/args.py 90.51% <100.00%> (+0.08%) ⬆️
dpgen2/exploration/selector/conf_selector_frame.py 100.00% <100.00%> (ø)
dpgen2/fp/gaussian.py 93.33% <100.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, but I don't quite understand here why not run a nopbc MD simulation directly.

@wanghan-iapcm
Copy link
Author

Approve, but I don't quite understand here why not run a nopbc MD simulation directly.

The MD simulation is nonpbc, the input file is provided as a template, so we do not explicitly set non-pbc in lammps MD input.

@wanghan-iapcm wanghan-iapcm merged commit 67c19d6 into deepmodeling:master Dec 25, 2022
@wanghan-iapcm wanghan-iapcm deleted the rm-pbc branch December 25, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants