Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse of repeated parameters in config #112

Closed
yurakuratov opened this issue Mar 15, 2018 · 2 comments
Closed

Reuse of repeated parameters in config #112

yurakuratov opened this issue Mar 15, 2018 · 2 comments
Assignees

Comments

@yurakuratov
Copy link
Contributor

Sometimes duplicated parameters with equal values may appear in config file.

Look at the example below:

"pipe": [
{
"name": "squad_preprocessor",
"context_limit": 400,
"question_limit": 150,
"char_limit": 16,
},
{
"name": "squad_vocab_embedder",
"context_limit": "#squad_prepr.context_limit",
"question_limit": "#squad_prepr.question_limit",
"char_limit": "#squad_prepr.context_limit",
{
"name": "squad_vocab_embedder",
"level": "char",
"context_limit": "#squad_prepr.context_limit",
"question_limit": "#squad_prepr.question_limit",
"char_limit": "#squad_prepr.char_limit",
},
{
"name": "squad_model",
"id": "squad",
"word_emb": "#vocab_embedder.emb_mat",
"char_emb": "#char_vocab_embedder.emb_mat",
"context_limit": "#squad_prepr.context_limit",
"question_limit": "#squad_prepr.question_limit",
"char_limit": "#squad_prepr.char_limit",
}
]

It could be more convenient if there was no need to copy context_limit, question_limit, char_limit and to fill them from something like global parameters scope.

@yoptar yoptar self-assigned this Sep 26, 2018
@yoptar
Copy link
Contributor

yoptar commented Sep 26, 2018

This can also be used for paths with default values for configs, requirements and data

@yoptar
Copy link
Contributor

yoptar commented Nov 15, 2018

Done in #574

@yoptar yoptar closed this as completed Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants