Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing #115

Closed
zenoone opened this issue May 15, 2023 · 1 comment
Closed

Improve testing #115

zenoone opened this issue May 15, 2023 · 1 comment
Assignees

Comments

@zenoone
Copy link
Collaborator

zenoone commented May 15, 2023

The current regression tests are prone to numerical instabilities. Increasing tolerances and running them on the cpu helped, but does not fully eradicate the problem. A further increase of the tolerances eventually defies the purpose of the tests as the numerical noise can cover up actual changes, leading to a false sense of security. A better solution would be to rework the testing and split the numerically challenging regression tests into smaller unit tests. In this effort the test coverage should be further increased.

@zenoone zenoone self-assigned this May 15, 2023
@szbernat szbernat changed the title Improve teststing Improve testing Oct 20, 2023
@zenoone
Copy link
Collaborator Author

zenoone commented Aug 14, 2024

In preparation with the next update of deepqmc.

@zenoone zenoone closed this as completed Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant