Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear where experiments folder is #6

Closed
equaeghe opened this issue Oct 7, 2021 · 3 comments · Fixed by #9
Closed

Unclear where experiments folder is #6

equaeghe opened this issue Oct 7, 2021 · 3 comments · Fixed by #9
Assignees
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@equaeghe
Copy link

equaeghe commented Oct 7, 2021

I installed deeprob-kit using pip:

$ pip install --user deeprob-kit

Now, I want try out the experiments to see if the code works on my system. However, I do not seem to have the experiments folder and therefore do not seem to be able to run them or put the datasets in place. Namely, what I have after installation is the following tree:

~/.local/lib/python3.9 $ tree -L 3
.
└── site-packages
    ├── deeprob
    │   ├── __init__.py
    │   ├── __pycache__
    │   ├── context.py
    │   ├── flows
    │   ├── spn
    │   ├── torch
    │   └── utils
    └── deeprob_kit-1.0.0.dist-info
        ├── INSTALLER
        ├── LICENSE
        ├── METADATA
        ├── RECORD
        ├── REQUESTED
        ├── WHEEL
        └── top_level.txt

8 directories, 9 files

My impression is that the bundle on PyPi only contains deeprob-kit itself, without any of the other materials. Perhaps putting the experiments folder (and others) under deeprob may provide a solution, but I guess you chose the current structure for a reason. Or perhaps I am looking in the wrong location.

@loreloc
Copy link
Member

loreloc commented Oct 7, 2021

The PIP package contains only the deeprob module, i.e. the library without examples, unit tests, benchmark and experiments. I didn't put those directories because I thought a PIP package of a library shouldn't contain development and experiments related code, since they are not part of the library itself.

However, if you wish to run the experiments (and examples), probably it's better to clone the repository and work from that.

@loreloc loreloc added the question Further information is requested label Oct 7, 2021
@equaeghe
Copy link
Author

equaeghe commented Oct 7, 2021

That makes sense. I now looked around to see if any other projects include those things, but I've only come across mention of including examples as executables supplied by the project. But that might just clutter the module's install. One other thing that popped up is that using an intermediate src/ folder seems advised, but that is another topic.

In any case, then this issue can be considered as a request to update the Readme to make this point about examples and experiments requiring a git clone clear.

@loreloc
Copy link
Member

loreloc commented Oct 8, 2021

Sounds good, so this issue is related to #3.

@loreloc loreloc added this to To do in DeeProb-kit v1.0.x Board via automation Oct 8, 2021
@loreloc loreloc added the documentation Improvements or additions to documentation label Oct 8, 2021
@loreloc loreloc self-assigned this Oct 13, 2021
@loreloc loreloc moved this from To do to In progress in DeeProb-kit v1.0.x Board Oct 13, 2021
DeeProb-kit v1.0.x Board automation moved this from In progress to Done Oct 13, 2021
gengala added a commit that referenced this issue Oct 13, 2021
PR for documentation issues #3 and #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants