-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refactor LLMOptions #28
Conversation
Trivy scanning results. |
Code Coverage Summary
Diff against main
Results for commit: 6439a71 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write a test (for me can be an integration one that if we execute collection.ask() all LLM Options propagate correctly. + test the or operator
Also the issue with openai dependency is important.
Rest for me is optional, I'll accept the PR if without them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR adds default LLM options for LLM client and enables custom LLM parameterization in
collection.ask
.