Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output_dir parameter in run by config is being ignored #39

Closed
tripl3a opened this issue Aug 4, 2019 · 2 comments
Closed

output_dir parameter in run by config is being ignored #39

tripl3a opened this issue Aug 4, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@tripl3a
Copy link
Contributor

tripl3a commented Aug 4, 2019

If you set the parameter like this:

    "output_dir": {"value": "/path/to/output", "default": "", "desc": "Output directory where model predictions and checkpoints will be saved."},

You will get an error if the directory already exists and the run will stop.

If the director does not exist the run will be successfully executed but the directory will be empty afterwards and the log will contain such entries:

08/03/2019 15:11:20 - WARNING - farm.file_utils -   Path saved_models/bert-german-GermEval18Coarse already exists. You might be overwriting files.
@tripl3a
Copy link
Contributor Author

tripl3a commented Aug 4, 2019

Also dev_sizeis being ignored. Trying the three following configurations always defaulted to dev_size=0.1.

    "dev_size":         {"value": [0.2,0.3], "default": 0.1, "desc": "Split a dev set from the training set using dev_size as proportion."}
    "dev_size":         {"value": 0.2, "default": 0.1, "desc": "Split a dev set from the training set using dev_size as proportion."}
    "dev_size":         {"value": null, "default": 0.2, "desc": "Split a dev set from the training set using dev_size as proportion."}

@tholor tholor added the bug Something isn't working label Aug 5, 2019
tanaysoni added a commit that referenced this issue Aug 5, 2019
This commit implements use of the `output_dir` param in configs.
tanaysoni added a commit that referenced this issue Aug 6, 2019
* Implement use of the `output_dir` param for saving models

* Set the default value of `output_dir` to `saved_models`
@tanaysoni
Copy link
Contributor

Hi @tripl3a. Thank you for reporting the issue. It is resolved by #43.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants