Refactor squad qa #131
Merged
Refactor squad qa #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion for each sample only
…ter probabilities, improved sample printing.
tholor
reviewed
Oct 31, 2019
There was a problem hiding this comment.
Great job! I have a couple of smaller remarks but I don't see any big blockers.
As you said, we might wanna do some refactoring of the inferencer afterwards to have it cleaner. But it might be also valid to wait for the bigger QA redesign in https://github.com/deepset-ai/FARM/tree/qa_redesign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes
QA eval during training
working QA inference mode
missing: support for other models except Bert