Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Params in Question Answering Head #183

Merged
merged 3 commits into from Jan 6, 2020
Merged

Params in Question Answering Head #183

merged 3 commits into from Jan 6, 2020

Conversation

brandenchan
Copy link
Contributor

The params n_best, context_window_size and no_ans_threshold can now be set when initializing QuestionAnsweringHead

Timoeller
Timoeller reviewed Jan 6, 2020
View reviewed changes
Copy link
Contributor

@Timoeller Timoeller left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking ok, though why did you remove the n_best changes again?

@brandenchan
Copy link
Contributor Author

Looking ok, though why did you remove the n_best changes again?

That was a mistake. I have recommitted them

@Timoeller Timoeller self-requested a review January 6, 2020 14:26
Timoeller
Timoeller approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lets merge!

@brandenchan brandenchan merged commit 87a51e7 into master Jan 6, 2020
@tholor tholor deleted the ph_params branch April 28, 2020 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timoeller Timoeller Timoeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brandenchan @Timoeller