Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement next_sent_pred flag #198

Merged
merged 2 commits into from
Jan 17, 2020
Merged

Implement next_sent_pred flag #198

merged 2 commits into from
Jan 17, 2020

Conversation

brandenchan
Copy link
Contributor

Previously the next_sent_pred argument in the BertStyleLMProcessor was not working if the NextSentenceHead is passed to the adaptive model. Now the NextSentenceHead will be removed from the Adaptive model if next_sent_pred=True. This allows for turning off NSP by just setting the argument to False.

@brandenchan
Copy link
Contributor Author

This also works for the case where just one prediction head is passed into the Adaptive Model

Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@tholor tholor merged commit 14d1e5b into master Jan 17, 2020
@tholor tholor deleted the next_sent_pred branch April 28, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants