Add option for custom loss aggregation of heads #220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Each prediction head produces a loss that gets then aggregated to a full model loss. So far we used
sum()
as the aggregation function.Problem:
This is not optimal in the case of multiple PHs as it impacts the scale of the loss and therefore might require adjustments of the learning rate.
It also doesn't allow weighting of different prediction heads, where one task might be more important or just on a different loss scale.
Solution:
I would suggest to make this more flexible and let the user define a custom strategy via
loss_aggregation_fn
, which can be passed when initializing the AdaptiveModel.Default of
loss_aggregation_fn
will be sum(), but you can configure any fn that [Tensor, Tensor ...] and returns a single Tensor.Example:
Related to discussion in #182
What do you think @johann-petrak ?
Would that also cover your use cases?