Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maked use of 'language' **kargs if present in LanguageModel.load. #262

Merged
merged 1 commit into from Feb 21, 2020
Merged

Maked use of 'language' **kargs if present in LanguageModel.load. #262

merged 1 commit into from Feb 21, 2020

Conversation

ftesser
Copy link
Contributor

@ftesser ftesser commented Feb 21, 2020

This PR Fix #261

Because the language was set by the use of the class method _infer_language_from_name
I implemented a new class methos _get_or_infer_language_from_name that takes into account the language **kargs.

tholor
tholor approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for adding this @ftesser !

@tholor tholor merged commit 58f67cc into deepset-ai:master Feb 21, 2020
@tholor tholor added bug Something isn't working part: model labels Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
bug Something isn't working part: model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

farm.modeling.language_model.load does not make use of 'language' **kargs if present
2 participants
@ftesser @tholor