Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the option to define the language model class manually #264

Merged
merged 3 commits into from
Feb 21, 2020
Merged

Add the option to define the language model class manually #264

merged 3 commits into from
Feb 21, 2020

Conversation

ftesser
Copy link
Contributor

@ftesser ftesser commented Feb 21, 2020

This is a solution for #263

tholor
tholor approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for your work @ftesser. This is indeed helpful if the model class cannot be inferred from the name.

I only updated the doc string slightly.

@tholor tholor added enhancement New feature or request part: model labels Feb 21, 2020
@tholor tholor merged commit 88f5a68 into deepset-ai:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request part: model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ftesser @tholor