Add conversion of lm_finetuned to HF transformers #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tholor
reviewed
Mar 23, 2020
| ph_state_dict["transform.dense.bias"] = ph_state_dict.pop("dense.bias") | ||
| ph_state_dict["transform.LayerNorm.weight"] = ph_state_dict.pop("LayerNorm.weight") | ||
| ph_state_dict["transform.LayerNorm.bias"] = ph_state_dict.pop("LayerNorm.bias") | ||
| transformers_model.cls.predictions.load_state_dict(ph_state_dict) |
There was a problem hiding this comment.
I think you are converting here to a model with an MLM head but no NSP. AutoModelForPreTraining would give you a transformers model with both. I think for now we can keep it like this, as NSP is not that popular anymore these days and the FARM models might also only have the MLM head. However, please log an info message here like: "Converted to Transformer's 'AutoModelWithLMHead' with an MLM head only. No next sentence prediction head!"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for models that have been lm finetuned in FARM to be converted to a HuggingFace Transformers model