fix accuracy metric for nested lists of diff lengths #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timoeller
suggested changes
Aug 1, 2019
…erent lengths (as for example produced by the masked LM head)
tholor
force-pushed
the
fix_acc_masked_lm
branch
from
c698f49
to
206afdc
Compare
|
Changed it as suggested to a flat list conversion. That's way cleaner now. Please review and merge @Timoeller |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adresses issue #30
The suggested fix is to pad the lists to equal length before converting to a numpy array and then ignoring the PAD elements in the calculation of the metric.