Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-validation for Question-Answering #335

Merged
merged 20 commits into from
Apr 25, 2020
Merged

Cross-validation for Question-Answering #335

merged 20 commits into from
Apr 25, 2020

Conversation

bogdankostic
Copy link
Contributor

@bogdankostic bogdankostic commented Apr 22, 2020

This PR adds cross validation for Question Answering.
It is especially useful for evaluating small QA Domain datasets with long documents.

Features:

  • Optimally balanced document wise splitting of folds (realistic splits)
  • Down sampling of negative examples in train set (useful for long documents)
  • New recall @ n metric that uses multiple predictions

Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the test for tensor indices.
Apart from that it looks very good.

farm/data_handler/data_silo.py Show resolved Hide resolved
@bogdankostic bogdankostic changed the title WIP Cross-validation for Question-Answering Cross-validation for Question-Answering Apr 24, 2020
@Timoeller Timoeller merged commit 5398d6f into master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants