Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust code to squad inferencing #367

Merged
merged 2 commits into from May 14, 2020
Merged

Conversation

Timoeller
Copy link
Contributor

No description provided.

Copy link
Contributor

@brandenchan brandenchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Timoeller Timoeller merged commit b4c0fdb into natural_questions May 14, 2020
brandenchan added a commit that referenced this pull request May 27, 2020
)

* WIP: Messily adding NQ support

* WIP: NQ example

* WIP: NQ data tokenized (very messy)

* WIP: need to work on process_answers

* WIP: Samples created

* WIP: Data can be featurized

* WIP: IDs featurized

* WIP: NQ training can run

* WIP: Working on downsampling is_impossible

* WIP: Processor can downsample is_impossible

* WIP: dealing with multi head inf aggregation

* WIP: first attempt at merge()

* WIP: Fixing merge fn

* WIP: fixing merge

* WIP: implement Span and DocumentPred classes

* WIP: Fixing SQuAD

* WIP: Fixes for SQuAD

* WIP: NQ and Squad seem to run through

* Code cleanup and commenting

* Set better default

* Refactor formatted_preds()

* Fix some tests not all

* Addresses reviewer's comments

* Addresses more of reviewer's comments

* Fix input dict conversion

* Remove rest_api_schema

* All tests pass

* Remove class method from child Class

* nq test implemented

* add test data for nq

* Adjust code to squad inferencing (#367)

* Flatten prediction lists in adaptiive model

* Add squad question id to output dict in inference mode

* Fix qa id issue, adjust tests

* Add nq output to nq inferencing

* Allows download of sample dataset

* Add html tag tokens to vocab

* Add downsampling before dataprocessing

* Add loading of trained model to example script

* Add classification field to test

Co-authored-by: Timo Moeller <timo.moeller@deepset.ai>
Timoeller added a commit that referenced this pull request Dec 23, 2020
* Flatten prediction lists in adaptiive model

* Add squad question id to output dict in inference mode

Former-commit-id: b4c0fdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants